Fix @Import with multiple bean registrars
#35653
Closed
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
force-pushed
the
import-multiple-registrars
branch
from
8ae4bc1 to
a9c0026
Compare
spring-projects-issues
added
the
status: waiting-for-triage
wakingrufus
force-pushed
the
import-multiple-registrars
branch
from
a9c0026 to
3e16de4
Compare
…ir own class name rather than the class they are imported to This allows multiple BeanRegistrars to be imported from the same Configuration class fixes spring-projects#35652 Signed-off-by: wakingrufus <[email protected]>
wakingrufus
force-pushed
the
import-multiple-registrars
branch
from
3e16de4 to
d7e950d
Compare
sdeleuze
added
type: bug
sdeleuze
changed the title
@Import with multiple BeanRegistrars
sdeleuze
changed the title
@Import with multiple BeanRegistrars@Import with multiple bean registrars
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Oct 20, 2025
This commit add a test for multiple bean registrars imported by the same configuration class. See spring-projectsgh-35653 Signed-off-by: wakingrufus <[email protected]>
|
@wakingrufus I kept your test from the PR but fixed the bug in a different way, as we want to keep exposing the configuration class metadata, not the registrar one. Thanks for catching this pretty serious bug before the GA! |
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ConfigurationClassParser so that
@Imported BeanRegistrars use their own class name rather than the class they are imported toThis allows multiple BeanRegistrars to be imported from the same Configuration class
fixes #35652